Open
Conversation
Contributor
|
pdr has always been pretty unstable. This is why it was originaly removed from pandas. Looking at the test fails, some are due to values changing from providers for historical data. This happens for many reasons, e.g., a historical correction. Happy to have AI assisted patches, but I think some of the fixes need human guidance. |
Contributor
|
This PR is already getting heavy. I am mostly on board with what SciPy is doing with heavy AI PRs since thye often produce too many wide changes to be practically reviewable. To be clear, this isn't a no to this, but it needs to be kept in a range to be reviewed. |
added 7 commits
April 10, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffblack --check pandas_datareader