test(release): await publication helper cleanup - #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Preview run 33542756415 passed the consumer locking assertions in offline pack (b), then fixture cleanup failed with
ENOTEMPTYwhile removing its uniquepylon-consumer-lock-*directory.Root cause
The publication test did not own child-process lifetime at fixture scope. A helper error could settle before
close, and a rejected concurrent helper could leave sibling writers running while the test enteredfinally. The liveproper-lockfilefixtures also kept their timer-backed writer in the test process without an explicit process and file-handle quiescence boundary.Fix
ChildProcesshandle and settle helper results only afterclose.Verification
npm run test:pylon-publication(3 consecutive passes, 33/33 each)node --test scripts/pylon-publication.test.mjscopies (both pass, 33/33 each)npm run test:pylon-release(10/10)npm run test:pylon-ruleset-auditor-app(6/6)npm run checkgit diff --cached --checkOpenAI Codex GPT-5.6 / Prime Agent
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.