Fix bottle oldest bug#255
Merged
ocefpaf merged 2 commits intopyoceans:mainfrom May 8, 2026
Merged
Conversation
Member
Author
|
It turns out chardet became slopware after v6 and it wrecking havoc in all libraries that rely on it. I'm pinning to |
ocefpaf
force-pushed
the
fix_bottle_oldest_bug
branch
from
2bbaf0e to
7b2b87e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long term goal should be replace the custom pandas reader with
seabirdfilehandler, until then I'm just updating to ensure pandasinfercolumns is used to avoid getting the wrong values in bottle ros files.I'm also using coerce to numeric instead of a more error tolerant way to ensure malformed files can e partially read. The user can figure out why they are getting NaNs by comparing with the original values.