feat: build and push branch images tagged with the branch name - #84
Open
MateoLostanlen wants to merge 9 commits into
Open
feat: build and push branch images tagged with the branch name#84MateoLostanlen wants to merge 9 commits into
MateoLostanlen wants to merge 9 commits into
Conversation
- pass COMPONENT/BRANCH to the script via environment to prevent shell injection through branch names - keep nested branch components in the tag (feat/team/foo -> team-foo) - document that deploy-one-engine targets hosts_prod, with the preprod alternative
MateoLostanlen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/build-push-images.shto build a PR branch of the api (pyronear/pyro-api->alert-api), engine (pyro-engine->pyro-engine+pyro-camera-api) or platform (new-pyro-platform->pyro-platform-react) and push it to Docker Hub tagged with the branch name, for testing on preprod before merge. The tag drops the branch's type prefix and sanitizes invalid characters (feat/my-fix->my-fix), so CI's:latestis never overwritten.platform_react_docker_version/alert_api_docker_versioninenvpreprod,pyro_engine_docker_tagin the engine'shost_vars) and redeploy; the Readme documents the full walkthrough.linux/amd64for api/platform (servers),linux/arm64for engine images (Raspberry Pi). The platform app is built with pnpm in a throwawaynode:24container before the docker build, matching CI.make build-push COMPONENT=<api|engine|platform> BRANCH=<branch>host target; requires docker with buildx and a Docker Hub login with push rights on the pyronear org. COMPONENT/BRANCH are passed via the environment so branch names cannot inject shell commands.