fix(ui): drop the toast below the localize editor's top bar - #383
Merged
Conversation
The toast sat at top-4, 16px into a viewport whose top 48px the localize object editor fills with its own bar — including the close button on the same right edge the toast anchors to. Accepting a box covered the control the reader was reaching for. top-16 clears that bar with the same 16px breathing room the toast had against the page edge before.
Moving the toast to top-16 app-wide traded one covered control for another: with no overlay up, 64px is where the localize rail's own header starts, and the toast landed on its FP toggle — a button, where before it covered only the page header's progress badge. So the drop is now conditional. The localize object editor and the add-object overlay are the two things that pin a 48px bar across the top, and the toast clears it exactly while one of them is mounted.
Chouffe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepting a box in the localize object editor raised a toast that landed on the editor's own top bar — squarely on the close button the reader reaches for next. The toast is pinned at
top-4, 16px into a viewport whose top 48px the editor fills with its bar, and both anchor to the same right edge.NotificationSystemgrows abelowTopBarflag that drops it totop-16, clearing such a bar with the same 16px of airtop-4leaves against the viewport edge.LocalizeAlertPagesets it while either full-screen overlay is mounted — the object editor or the add-object overlay, which raises an identical bar (AddObjectOverlay.tsx:366).The drop is deliberately not the app-wide default. With no overlay up, 64px is where the cockpit's own content starts: the rail card's header row carries the FP-toggle button at the same right edge (
LocalizeRail.tsx:29-36,LocalizeAlertPage.tsx:2074), so an unconditionaltop-16would trade a covered progress badge for a covered button. Conditioning on the overlay costs one prop and covers neither.Verification
top-16, one raised from the alert page attop-4.falsefails only the editor test, forcing ittruefails only the alert-page test. Neither is vacuous.npm run type-check,npm run lint(--max-warnings 0), Prettier all clean./localize/6116/object/6116/100170.