feat(proxy): camera azimuth endpoints - #659
Merged
Merged
Conversation
Proxy GET /control/azimuth and POST /control/move_to_azimuth to the camera API. Bump pyro-camera-api-client to a rev exposing the new methods (feature branch rev, to re-bump once pyro-engine merges).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 93.73% 93.74%
=======================================
Files 59 59
Lines 3143 3147 +4
=======================================
+ Hits 2946 2950 +4
Misses 197 197 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fe51
requested changes
Aug 3, 2026
fe51
left a comment
fe51
left a comment
Member
There was a problem hiding this comment.
Hi @MateoLostanlen thank you for the quick PR !
Could you resove the small UV lock conflict and we will be ready to merge :)
Member
Author
|
@fe51 done :) |
fe51
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /{camera_id}/control/azimuth(read scope) to the camera device API, so the platform can display the live camera orientation during a live session. Companion of feat(camera): azimuth tracking and move-to-azimuth for PTZ cameras pyro-engine#390.pyro-camera-api-clientto a rev exposing the new client method. It currently points to the pyro-engine feature branch; re-bump to the merge commit once feat(camera): azimuth tracking and move-to-azimuth for PTZ cameras pyro-engine#390 lands.Note: a
move_to_azimuthproxy endpoint was initially part of this PR but was moved out to keep the scope on azimuth tracking; it will come back in a follow-up PR.