refactor: Simplify expo, decay, and fibo wait generators - #188
Merged
Conversation
Replace per-iteration recomputation (`factor * base_n`, `initial_value * e**(-t*decay_factor)`, the `if/else` branch in `fibo`) with a loop that grows the value multiplicatively until it crosses the cap, then falls into an unconditional loop yielding the capped value. Avoids recomputing the closed-form expression on every yield. Since `decay`'s multiplicative accumulation can drift slightly from the old direct power computation, the corresponding tests now compare with `pytest.approx` instead of exact equality; this also replaces the file-wide float-equality ruff suppression with per-assertion `approx` calls. Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace per-iteration recomputation (
factor * base_n,initial_value * e**(-t*decay_factor), theif/elsebranch infibo) with a loop that grows the value multiplicatively until it crosses the cap, then falls into an unconditional loop yielding the capped value. Avoids recomputing the closed-form expression on every yield.Since
decay's multiplicative accumulation can drift slightly from the old direct power computation, the corresponding tests now compare withpytest.approxinstead of exact equality.