feat(testing): updated ensure-zookeeper-env.sh to match minimum version of zk#776
Conversation
7f62062 to
d6ac80d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 96.67% 96.70% +0.02%
==========================================
Files 27 27
Lines 3553 3554 +1
==========================================
+ Hits 3435 3437 +2
+ Misses 118 117 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
696dc31 to
bc36c6b
Compare
StephenSorriaux
left a comment
There was a problem hiding this comment.
Thank you for taking care of my old TODO.
|
9f2c852 to
99c9edb
Compare
|
Can you please amend your commit and match the contribution guideline? Just adding |
|
@StephenSorriaux oops - hope that worked. it dismissed your review again... |
c1da969 to
a429e4f
Compare
These changes allow people to build locally with a reasonable chance of success making PRs a bit less likely to fail.
Also updated
.gitignoreto cover a few local files when developing with visual studioWhy is this needed?
ZOOKEEPER_VERSIONenv variable isn't exported.gitignoreto assist in local builds with visual studio codeProposed Changes
workflows/testing.ymlensure-zookeeper-env.shso ifZOOKEEPER_VERSIONwasn't supplied, to select the lowest (at the time of writing) supported version of zookeeper and export the variable.gitignoreto include.*_cacheandvenv*as this makes them greyed out in visual studio codeDoes this PR introduce any breaking change?
No