Skip to content

feat(testing): updated ensure-zookeeper-env.sh to match minimum version of zk#776

Merged
StephenSorriaux merged 1 commit intopython-zk:masterfrom
ThosRTanner:chore-update-ensure-env
May 3, 2026
Merged

feat(testing): updated ensure-zookeeper-env.sh to match minimum version of zk#776
StephenSorriaux merged 1 commit intopython-zk:masterfrom
ThosRTanner:chore-update-ensure-env

Conversation

@ThosRTanner
Copy link
Copy Markdown
Contributor

@ThosRTanner ThosRTanner commented Apr 25, 2026

These changes allow people to build locally with a reasonable chance of success making PRs a bit less likely to fail.

Also updated .gitignore to cover a few local files when developing with visual studio

Why is this needed?

  • Building kazoo locally would fail because the ZOOKEEPER_VERSION env variable isn't exported
  • The currently selected default version was way short of the minimum supported version, resulting in odd failures when building locally, and odd failures in PR builds
  • Also added some stuff to .gitignore to assist in local builds with visual studio code

Proposed Changes

  • Move all optional settings into ensure-zookeeper-env.sh out of workflows/testing.yml
  • Change ensure-zookeeper-env.sh so if ZOOKEEPER_VERSION wasn't supplied, to select the lowest (at the time of writing) supported version of zookeeper and export the variable
  • Updated .gitignore to include .*_cache and venv* as this makes them greyed out in visual studio code

Does this PR introduce any breaking change?

No

@ThosRTanner ThosRTanner force-pushed the chore-update-ensure-env branch from 7f62062 to d6ac80d Compare April 25, 2026 21:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.70%. Comparing base (86e69f2) to head (a429e4f).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   96.67%   96.70%   +0.02%     
==========================================
  Files          27       27              
  Lines        3553     3554       +1     
==========================================
+ Hits         3435     3437       +2     
+ Misses        118      117       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThosRTanner ThosRTanner force-pushed the chore-update-ensure-env branch 2 times, most recently from 696dc31 to bc36c6b Compare April 26, 2026 20:15
Copy link
Copy Markdown
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of my old TODO.

@ThosRTanner
Copy link
Copy Markdown
Contributor Author

Thank you for taking care of my old TODO.
No probs. I think you need to re-review it after I merged it but at least it's not complaining about coverage now!

StephenSorriaux
StephenSorriaux previously approved these changes May 2, 2026
StephenSorriaux
StephenSorriaux previously approved these changes May 2, 2026
@StephenSorriaux
Copy link
Copy Markdown
Member

Can you please amend your commit and match the contribution guideline? Just adding feat(testing): before the current message would be enough. That helps when we auto generate the changelog for a release.

@ThosRTanner
Copy link
Copy Markdown
Contributor Author

@StephenSorriaux oops - hope that worked. it dismissed your review again...

@ThosRTanner ThosRTanner closed this May 2, 2026
@ThosRTanner ThosRTanner reopened this May 2, 2026
@ThosRTanner ThosRTanner changed the title chore: updated ensure-zookeeper-env.sh to match minimum version of zk feat(testing): updated ensure-zookeeper-env.sh to match minimum version of zk May 3, 2026
@ThosRTanner ThosRTanner force-pushed the chore-update-ensure-env branch from c1da969 to a429e4f Compare May 3, 2026 08:23
Copy link
Copy Markdown
Member

@StephenSorriaux StephenSorriaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@StephenSorriaux StephenSorriaux merged commit 177da78 into python-zk:master May 3, 2026
38 checks passed
@ThosRTanner ThosRTanner deleted the chore-update-ensure-env branch May 3, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants