gh-148278: Fix try except block bug#148333
Open
Shubham-Developer02 wants to merge 2 commits intopython:mainfrom
Open
gh-148278: Fix try except block bug#148333Shubham-Developer02 wants to merge 2 commits intopython:mainfrom
Shubham-Developer02 wants to merge 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tryregions by labeling block-setup and block-pop pseudos with the active handler inlabel_exception_targets().tryentry inco_exceptiontable.Fixes #148278.
Details
label_exception_targets()assignsinstr->i_except, which becomesco_exceptiontableranges after assembly. Previously:SETUP_FINALLY(and otheris_block_pushinstructions) updated the internal except stack but did not setinstr->i_except, so the start of the protected span could be absent from the table.POP_BLOCKwas rewritten toNOPwithout settinginstr->i_except, which could split or omit coverage for the following instruction (notablycontinue’s backward jump, or minimal try bodies).The fix sets
instr->i_exceptappropriately for those instructions so tracing and pending exceptions on those offsets resolve to the intendedexcepthandler.Tests
Lib/test/test_compile.py(TestSpecifics):test_while_continue_try_except_exception_tabletest_try_literal_stmt_exception_table