gh-158200: Harden faulthandler against freed code metadata - #158202
Open
Alishahryar1 wants to merge 1 commit into
Open
Alishahryar1 wants to merge 1 commit into
Alishahryar1 wants to merge 1 commit into
Conversation
Alishahryar1
force-pushed
the
ali/faulthandler-code-metadata
branch
from
September 26, 2026 05:06
99ac055 to
2ce7ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
faulthandler.dump_traceback_later()walks other threads without acquiring the GIL so it can diagnose deadlocks. If a target thread releases its current code object during that walk, the watchdog can dereference freed filename, function-name, or line-table metadata and crash instead of producing a diagnostic.Addresses #158200.
How
Guard code objects and their filename, function-name, line-table, and monitoring metadata before the lock-free traceback path reads them. Preserve readable later fields when one metadata field is invalid, and use
???only for unavailable fields. Load monitoring pointers with acquire semantics that match their existing release publication, and decode lines from a validated local line-table snapshot.These checks detect common freed-memory states but do not provide object-lifetime synchronization, so lock-free traversal remains best-effort during concurrent destruction.