gh-158217: Fix dbm.dumb bytearray keys - #158218
Open
Tony123-tech wants to merge 1 commit into
Open
Tony123-tech wants to merge 1 commit into
Tony123-tech wants to merge 1 commit into
Conversation
Tony123-tech
requested review from
corona10,
erlend-aasland and
serhiy-storchaka
as code owners
September 26, 2026 04:55
Tony123-tech
force-pushed
the
gh-158217-fix-dbm-dumb-bytearray-keys
branch
from
September 26, 2026 04:57
b4abca0 to
365e87f
Compare
Tony123-tech
force-pushed
the
gh-158217-fix-dbm-dumb-bytearray-keys
branch
from
September 26, 2026 04:57
365e87f to
c0ef434
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The isinstance check in _Database.setitem and related methods
accepted bytearray keys, but the in-memory index is a dict, and
bytearray is not hashable, so operations raised TypeError.
Convert bytearray keys to bytes before use in getitem,
setitem, delitem, and contains.