Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929
Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929iampujan wants to merge 9 commits intopython:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Deprecates and removes the legacy ProvidedSponsorshipAssetsView endpoint/template now that “provided assets” are surfaced directly within SponsorshipDetailView (sponsorship_detail.html).
Changes:
- Removed
ProvidedSponsorshipAssetsViewand its URL route. - Deleted the legacy
sponsorship_assets_view.htmltemplate and removed the “View all assets” link from the sponsorship detail page. - Updated provided-asset
user_view_urlto point to the sponsorship detail page’s “Provided Assets” section.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/users/views.py | Removes the deprecated ProvidedSponsorshipAssetsView. |
| apps/users/urls.py | Removes the provided-assets/ route. |
| apps/users/templates/users/sponsorship_detail.html | Removes the link to the deleted provided-assets page. |
| apps/users/templates/users/sponsorship_assets_view.html | Deletes the deprecated template. |
| apps/sponsors/models/benefits.py | Updates user_view_url to deep-link to the provided-assets section on the sponsorship detail page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iampujan
force-pushed
the
feature/issue-2611-deprecate-provided-assets-view
branch
from
bc076a2 to
ab8c75a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
apps/users/urls.py:42
- Removing the
sponsorships/<int:pk>/provided-assets/route will cause existing bookmarks/emails to start returning 404s. Consider keeping the old path as a RedirectView (or similar) tousers:sponsorship_application_detailwith the#provided-assets-infoanchor to preserve backward compatibility while deprecating the endpoint.
path(
"sponsorships/<int:pk>/",
views.SponsorshipDetailView.as_view(),
name="sponsorship_application_detail",
),
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| expected_url += "#provided-assets-info" | ||
|
|
||
| self.assertEqual(self.asset.user_view_url, expected_url) | ||
| self.assertIn("#provided-assets-info", self.asset.user_view_url) |
There was a problem hiding this comment.
The second assertion is redundant: assertEqual(self.asset.user_view_url, expected_url) already guarantees the anchor is present. Consider dropping the assertIn check (or replace with a more distinct assertion) to keep the test minimal.
| self.assertIn("#provided-assets-info", self.asset.user_view_url) |
Deprecates
ProvidedSponsorshipAssetsViewas its functionality is now wholly covered bySponsorshipDetailView. The old template and url have been removed.