refactor(runner): add the flow import resolver - #1512
Merged
Atchyut Preetham Pulavarthi (theonly1me) merged 1 commit intoAug 21, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Atchyut Preetham Pulavarthi (theonly1me)
marked this pull request as ready for review
August 21, 2026 09:54
Chase J (chajac)
approved these changes
Aug 21, 2026
Atchyut Preetham Pulavarthi (theonly1me)
merged commit Aug 21, 2026
ad44380
into
main
7 checks passed
Atchyut Preetham Pulavarthi (theonly1me)
deleted the
refactor/nova-1574-resolve-the-flow-import-graph
branch
August 21, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of Changes
qawolf runner runships every shippable file under the working directory, so on a workspace where a flow reaches ten files it collects thousands and the request is refused on size before it ever runs. A socket run does not do this: it walks the flow's import graph. This ports that resolver so the CLI can do the same, as pure functions with no disk access; the walk that uses them is a separate change.parseTsconfigPathsandresolvePathAlias, honouring only the first target of the first matching pattern as the socket path doesgetImports, collecting top-level static imports and dynamicimport()calls anywhere in the file, deduplicatedexport ... fromandrequire()stay invisible and the CLI ships the same file set a socket run doesresolveImportPath, resolving an alias against the project root and a relative import against the importing file's directory.ts,.js,/index.tsthen/index.js, never the bare path, and try the other supported extension when one is explicitnot-a-repository-importfor a bare specifier andunresolved-repository-importfor a relative or aliased import that matches nothingnode:path/posix, since collected paths always use forward slashes and backslashes would match nothing on Windowscore/stays free of I/O and nothing loads the compiler at runtime yet.tsxextensionTesting
bun run typecheck bun run lint --max-warnings 0 bun run format:check bun run knip bun run testbun testgives1788 pass 0 fail, 31 of them new. The other five give exit 0.bun run buildleavesdist/cli.jsat 7.1 MB with nocreateSourceFilein it, confirming the type-only compiler import erases and nothing new is bundled.bun.lockand snapshots: 453, over the 400 warning threshold inscripts/check-pr-size.shand under the 600 error threshold.