chore(cli): reserve runner.inspect from the public-API generator - #1516
chore(cli): reserve runner.inspect from the public-API generator#1516Erzhan Torokulov (erzhtor) wants to merge 0 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Adds `qawolf runner inspect session|contexts|page-source|elements` alongside the browser-only `element-html`/`page-html`/`variable` arms already on main, reading a mobile runner's Appium session, WebView contexts, page source, or elements — via the platform's separate `runner.inspectMobile` contract (qawolf/platform#31758), not by extending `runner.inspect`. `qawolf runner act` answers `action-not-supported-on-mobile` for `double_click`, `scroll`, `move`, `keypress`, `navigate`, and a `click` whose `--button` isn't `left` — none of those have a touchscreen equivalent. `--button` and `--path` note the mobile-specific behavior (left-only clicks, drag collapses to its path's first and last point). Screenshots need no change: the platform re-encodes a mobile device's screen to JPEG before answering, same as a browser, so the format-aware handling an earlier draft of this added is dropped as unnecessary. Depends on `@qawolf/api-contracts` publishing `runner.inspectMobile` and the mobile dispatch for `performAction` (ARC-556, platform PRs #31741/#31758/#31759). Until that lands, `inspectMobile.ts` and `inspectMobileRequest.ts` reference contract members the pinned `api-contracts` does not export yet, and `bun run typecheck`/`lint` fail on exactly those two files plus the new `performAction.ts` case — expected and scoped to this dependency, same as the two-PR stack this supersedes documented (#1516, #1517).
9ad8eea to
1e7f0af
Compare
|
Closing as superseded. Main already reserves `runner.inspect` (and the whole The mobile inspect work that actually depends on the reservation continues in #1517, rebased directly onto `main`. |
1 participant
Relates to ARC-556. Bottom of a 2-PR stack; #1517 is stacked on this.
Overview of Changes
@qawolf/api-contractswill publish arunner.inspectcontract once the platform side of ARC-556 merges (platform PRs #31741/#31758/#31759, all open). The moment that dependency bumps,bun run generatefails: the generator cannot turnrunner.inspect's discriminated-unionrequestinput into CLI flags, the same way it already can't forrunner.performAction's action union. This reserves the name in the hand-writtenrunner.*skip-list ahead of time, mirroring how the platform's own stack shipped contracts with no consumer yet (their PR2).No functional change. The name is inert against the currently published 0.26.0, which has no such contract — nothing today calls
runner.inspector reads it from the skip-list differently. The actual dependency bump (chore(deps): bump api-contracts to X.Y.Z) and theqawolf runner inspectcommand consuming it land in #1517, once the platform side publishes.Testing
bun run typecheck bun run lint bun run format:check bun run knip bun run test bun run buildChecklist