Skip to content

fix: add Apache license classifier - #711

Open
doogle-oss wants to merge 1 commit into
qdrant:mainfrom
doogle-oss:fix/license-classifier
Open

doogle-oss wants to merge 1 commit into
qdrant:mainfrom
doogle-oss:fix/license-classifier

Conversation

@doogle-oss

@doogle-oss doogle-oss commented Sep 19, 2026

Copy link
Copy Markdown

Summary

Adds the Apache Software License Trove classifier to the package metadata so PyPI correctly detects and displays FastEmbed as Apache-2.0 licensed.

Previously, PyPI showed the license as Other/Proprietary License (Apache License) because the package declared license = "Apache-2.0" but did not include the canonical PyPI classifier.

Fix the bug #712 with this change.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass the existing tests?
  • Have you added tests for your feature?
  • Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

New models submission:

  • Have you added an explanation of why it's important to include this model?
  • Have you added tests for the new model? Were canonical values for tests computed via the original model?
  • Have you added the code snippet for how canonical values were computed?
  • Have you successfully ran tests with your changes locally?

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4c97143a-c84c-4aa8-b5d7-c858836b2662

📥 Commits

Reviewing files that changed from the base of the PR and between cc4d101 and 829ac00.

📒 Files selected for processing (1)
  • pyproject.toml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The package metadata now includes an Apache Software License classifier.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the Apache license classifier.
Description check ✅ Passed The description directly explains the metadata change, the PyPI licensing issue, and the related bug.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@doogle-oss

Copy link
Copy Markdown
Author

the license is not detected in pypi.org and thus not able to use the lib in our organization. Added a quick fix, though the right way is to use [project] in pyproject.toml. I can make that change as well if needed. Do let me know.

@doogle-oss doogle-oss changed the title fix: add Apache license classifier fix: add Apache license classifier fix bug #712 Sep 19, 2026
@doogle-oss doogle-oss changed the title fix: add Apache license classifier fix bug #712 fix: add Apache license classifier Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant