fix: add Apache license classifier - #711
doogle-oss wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe package metadata now includes an Apache Software License classifier. Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
the license is not detected in pypi.org and thus not able to use the lib in our organization. Added a quick fix, though the right way is to use [project] in pyproject.toml. I can make that change as well if needed. Do let me know. |
Summary
Adds the Apache Software License Trove classifier to the package metadata so PyPI correctly detects and displays FastEmbed as Apache-2.0 licensed.
Previously, PyPI showed the license as
Other/Proprietary License (Apache License)because the package declaredlicense = "Apache-2.0"but did not include the canonical PyPI classifier.Fix the bug #712 with this change.
All Submissions:
New Feature Submissions:
pre-commitwithpip3 install pre-commitand set up hooks withpre-commit install?New models submission: