Add designation prefixes for 56 categories under 20_manufacturers_articles - #73
Open
ispyisail wants to merge 1 commit into
Open
Add designation prefixes for 56 categories under 20_manufacturers_articles#73ispyisail wants to merge 1 commit into
ispyisail wants to merge 1 commit into
Conversation
…icles Second batch from tools/iec81346 (qelectrotech-docker), same tooling and safety rules as qelectrotech#70's first batch (10_allpole/11_singlepole). This one covers manufacturer-specific PLC controllers, safety switches, frequency drives, softstarters, sensors, power supplies, relays, and a few allpole/graphics categories that hadn't been touched yet. Every insertion is a one-line addition to a category the file already lists -- no new <category> nodes, no reformatting elsewhere. Verified against the file's own scoring gate (0 contradictions with the 82 hand-curated entries) and by sampling every one of the 60 candidates the tool proposed by hand: 4 were dropped as false positives the tool's existing safety rules can't see (a flat folder with no sub-categories to disagree with each other, so nothing trips the "subtree wants a different prefix" check even though the folder mixes device types) -- 20_manufacturers_articles/guitar/pickups (matched "coil" but isn't a relay), 20_manufacturers_articles/knx/actionneur and .../capteurs (both heterogeneous KNX I/O catch-alls), and .../siemens/01_PLC_controllers/et200s/power_supply (its one element is actually a terminal module, not a power supply). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where this comes from
This is a follow-up to #70 (first batch,
10_allpole/11_singlepole), whichwas the data half of qelectrotech-source-mirror discussion
#666
(IEC 81346 designation letter) and PR
#668
(the mechanism that reads this file —
autonum::elementPrefixForLocation(),exposed as the
%prefixlabel-formula variable).More recently this became item 2 of
REFACTOR-BACKLOG.mdTier 2 inqelectrotech-docker,
which was itself written from a review of scorpio810's own refactor roadmap
(
refonte_du_code_de_qelectrotechon the QET wiki) — that doc separatelyproposes "a standards file mapping element types to letter codes", which
qet_labels.xmlalready is, just under-filled-in. This PR is coveragework against that same file, not a new mechanism.
What this does
Second batch from
tools/iec81346(in qelectrotech-docker), same toolingand safety rules as #70. Covers manufacturer-specific PLC controllers,
safety switches, frequency drives, softstarters, sensors, power supplies,
relays, and a few allpole/graphics categories
#70didn't touch.Every insertion is a one-line addition to a category the file already
lists — no new
<category>nodes, no reformatting elsewhere.Verification
Scored against the file's own gate: 0 contradictions with the 82
hand-curated entries.
The tool proposed 60 candidates; I sampled every one by hand against its
actual element contents rather than trusting the tool's own confidence.
4 were dropped as false positives the existing safety rules can't see (a
flat folder with no sub-categories has nothing to disagree with
internally, so the "subtree wants a different prefix" check never fires
even when the folder mixes device types):
20_manufacturers_articles/guitar/pickups→ matched the bare "coil"keyword, but a guitar pickup isn't a relay coil.
20_manufacturers_articles/knx/actionneur→ mostly genericbinary/analog I/O modules, not motors; also contains a valve and a
heater.
20_manufacturers_articles/knx/capteurs→ mixes real sensors withswitches, a timer, and an alarm.
20_manufacturers_articles/siemens/01_PLC_controllers/et200s/power_supply→ its one actual element is a terminal module, not a power supply.
(A small
--excludeflag was added topropose_labels.pyfor this —companion commit in qelectrotech-docker.)
🤖 Generated with Claude Code