fix(shell): the rail's visible search label honours labels.search - #35
Merged
Conversation
labels.search reached the collapsed button's tooltip and aria-label, while the expanded rail printed a hardcoded "Search". The one word an operator actually reads was the one word that could not be translated — in a kit whose stated rule is that strings are props with English defaults. A six-locale console would have shown English on every one of them. Refs qorpe/mockifyr#323.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
labels.searchreached the collapsed button's tooltip andaria-label. The expanded rail printed a hardcodedSearch.So the one word an operator actually reads was the one word that could not be translated — in a kit whose stated rule is "strings are props with English defaults". Mockifyr ships six locales; adopting the shell would have shown English on all six.
Found while implementing qorpe/mockifyr#323. One line, one test, no visual change (the gallery passes no labels, so the default still renders).