fix(shell): only the nav list scrolls, so the rail footer stays pinned - #37
Merged
Conversation
The whole rail was one scroller, so a console whose nav outgrew the viewport pushed its footer below the fold. The footer is where the tenant/service switcher lives — the control that scopes everything else on screen — and "scroll the sidebar to change tenant" is not a thing anybody should have to discover. Found adopting the shell in a console with twelve nav items across four groups: at a 720px viewport the rail measured 832px and the switcher started at y=707. The existing "the RAIL scrolls on its own" test is restated rather than deleted: the guarantee it protects — a long nav is not clipped — still holds, one element in. Baselines moved by a few pixels of vertical spacing; the rendering is otherwise identical. Refs qorpe/mockifyr#323. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole rail was one scroller. A console whose nav outgrows the viewport therefore pushes its footer below the fold — and the footer is where the tenant/service switcher lives, the control that scopes everything else on screen.
"Scroll the sidebar to change tenant" is not a thing anybody should have to discover.
Measured, not guessed
Adopting the shell in a console with twelve nav items across four groups (qorpe/mockifyr#323):
The change
The scroller moves one element in: the nav list scrolls, the head and footer are pinned around it. Same guarantee that a long nav is never clipped.
The existing "the RAIL scrolls on its own once many capabilities are composed" test is restated rather than deleted — its intent survives, its target moves.
Gates
190 tests · coverage 97.66/92.37/94.59/97.66 · docs · pin · typecheck all clean. Visual baselines moved by a few pixels of vertical spacing; the rendering is otherwise identical, which is what a structural change with no design intent should look like.