feat(sheet): body="bleed" hands padding and scrolling to the child - #41
Merged
Conversation
The panel wrapped its children in the one scrolling region. A detail panel whose tabs scroll their own panes therefore sat inside a second scroller, and two scrollbars racing each other make both feel broken. That is why mockifyr's journal and message panels stayed local even after the header slot landed: the header was only half of what they needed. The same choice AppShell offers for its content surface, with the same name and the same reason. The padded default is unchanged, and a test pins that. Baselines moved for the docs card's notes again, not the component. Refs qorpe/mockifyr#323.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel wrapped its children in the one scrolling region. A detail panel whose tabs scroll their own panes therefore sat inside a second scroller, and two scrollbars racing each other make both feel broken.
That is why mockifyr's journal and message panels stayed local even after the
headerslot landed in #39 — the header was only half of what they needed. Found by trying the migration rather than by reading the props again.The same choice
AppShelloffers for its content surface, with the same name and the same reason. §3's rule is one scroller per column; this is the sheet's version of it.The padded default is unchanged, and a test pins that too —
data-bodyis asserted both ways.194 tests · coverage 97.68 / 92.46 / 94.59 / 97.68 · docs · pin · typecheck clean. Baselines moved for the docs card's notes growing again, not the component.