fix: resolve failing tests across api and shared packages#24
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity bug (HTTP methods comparison) - Fix User type field name (userName → username) for consistency - Add missing badRequest helper in users route - Implement pagination utility to satisfy test expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicMethodsused lowercase"post"but Hono passes uppercase"POST"userNamefield tousernamein theUsertype to match usage across all tests and route handlersbadRequesthelper function (returns 400 JSON response) that was referenced but undefinedpaginatefunction to slice arrays and return{ data, page, pageSize, total, totalPages }as expected by the test suiteVerification
All 22 tests pass (
bun test). TypeScript compilation (npx tsc --noEmit) is clean for source files — remaining errors are only in test files due to missing@types/bundeclarations (expected in this setup; tests run correctly via Bun runtime).Assumptions
bun:testandprocesstype errors in test files are acceptable since they only affect IDE/tsc checks, not runtime behaviorbadRequesthelper was inlined in the users route rather than imported from an external module