fix: resolve all failing tests and type errors#28
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity: use 'POST' instead of 'post' in public methods list - Fix User type field name: rename 'userName' to 'username' for consistency - Add missing 'badRequest' import in users route handler - Implement pagination utility (paginate function) per test expectations - Add node types to tsconfig for process.env resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"but HTTP methods are uppercase — changed to"POST"so unauthenticated POST requests to public endpoints are correctly allowed.userNametousernamein the sharedUsertype to match what the API route handlers and tests expect.badRequestto the import from../lib/errorsin the users route handler.paginate()function inpackages/shared/src/utils/pagination.tsto satisfy the existing test expectations."node"tocompilerOptions.typesin the roottsconfig.jsonsoprocess.envresolves without errors.Verification
bun test→ 22 tests pass, 0 failuresnpx tsc --noEmit→ 0 type errorsAssumptions