fix: resolve all failing tests across utility library#183
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw Error on division by zero instead of returning Infinity - string-utils: fix wordCount to handle multiple consecutive spaces, implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: use Math.round instead of Math.floor for day calculation - validator: allow long TLDs in email validation, allow ports in URL validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dividenow throwsError("Division by zero")when divisor is 0 instead of returningInfinitywordCountto split on/\s+/regex (handles multiple consecutive spaces); implementedtruncatewith word-boundary-aware truncation and "..." suffixremove,update, andsortBymethodsformatRelativeday calculation fromMath.floortoMath.roundto fix off-by-one errorisEmailregex to allow TLDs of 2+ characters; fixedisUrlregex to allow optional port numbersTest Results
All 60 tests pass (previously 44 pass / 16 fail).
Assumptions
truncatetruncates at word boundaries when possible, falling back to hard truncation when no boundary fits within the limitsortBy("priority")orders high > medium > lowsortBy("createdAt")orders oldest firstsortBy("status")orders alphabetically (done < in-progress < todo)