Add regression test for ampersand in dart-sass paths (#14534)#14536
Open
cderv wants to merge 1 commit into
Open
Add regression test for ampersand in dart-sass paths (#14534)#14536cderv wants to merge 1 commit into
cderv wants to merge 1 commit into
Conversation
Cover the exact path pattern that broke v1.9 (e.g. C:\Users\Tom & Jerry\) to prevent re-regression. Mirrors the existing spaced/accented tests by junctioning the real dart-sass install dir into an ampersand-containing parent directory and asserting compilation succeeds. The junction itself is created via cmd /c mklink — Deno.Command passes each arg as a separate CreateProcess argument, so the ampersand in the target path is not interpreted by cmd.exe as a command separator.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dart.exe bypass landed in #14273 covers the ampersand-in-username regression (#14534) implicitly, but no regression test asserts that
dartCommandsucceeds when the dart-sass install dir contains&. Without it, a future refactor ofresolveSassCommandcould silently reintroduce the failure mode.The test junctions the bundled dart-sass install dir into a
Tom & Jerry/parent and runsdartCommandagainst it — exact pattern of the original failure reported in #14534.Cherry-picked from the v1.9 backport PR #14535 where the same coverage is added on the stable branch.
Related to