Walk the cause chain when dumping uncaught errors#1509
Merged
Conversation
bnoordhuis
approved these changes
May 24, 2026
Contributor
bnoordhuis
left a comment
There was a problem hiding this comment.
Maybe it should preserve rt->current_exception? Apart from that LGTM.
Contributor
Author
Goot point, pushed a fix that basically acts the way the previous code did with the stack property. |
qr243vbi
added a commit
to qr243vbi/quickjs
that referenced
this pull request
May 25, 2026
Walk the cause chain when dumping uncaught errors (quickjs-ng#1509)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example: