Quiet check (#2447)

* Don't require DT

Since we don't require covr

* Import from all used packages

* Quiet spelling checks

* Avoid R CMD check warning

* Reinstate correct version numbers

Author: hadley

DESCRIPTION

@@ -19,7 +19,6 @@ Depends:
 Imports: 
     cli (>= 3.3.0),
     desc (>= 1.4.1),
-    DT (>= 0.23),
     ellipsis (>= 0.3.2),
     fs (>= 1.5.2),
     lifecycle (>= 1.0.1),
@@ -47,6 +46,7 @@ Suggests:
     covr (>= 3.5.1),
     curl (>= 4.3.2),
     digest (>= 0.6.29),
+    DT (>= 0.23),
     foghorn (>= 1.4.2),
     gh (>= 1.3.0),
     gmailr (>= 1.0.1),

NAMESPACE

@@ -85,13 +85,15 @@ importFrom(cli,cat_rule)
 importFrom(ellipsis,check_dots_used)
 importFrom(lifecycle,deprecated)
 importFrom(memoise,memoise)
+importFrom(miniUI,miniPage)
 importFrom(pkgbuild,clean_dll)
 importFrom(pkgbuild,find_rtools)
 importFrom(pkgbuild,has_devel)
 importFrom(pkgbuild,with_debug)
 importFrom(pkgload,check_dep_version)
 importFrom(pkgload,parse_deps)
 importFrom(pkgload,unload)
+importFrom(profvis,profvis)
 importFrom(remotes,dev_package_deps)
 importFrom(remotes,github_pull)
 importFrom(remotes,github_release)
@@ -110,6 +112,7 @@ importFrom(remotes,update_packages)
 importFrom(sessioninfo,package_info)
 importFrom(sessioninfo,session_info)
 importFrom(stats,update)
+importFrom(urlchecker,url_check)
 importFrom(usethis,ui_code)
 importFrom(usethis,ui_done)
 importFrom(usethis,ui_field)

NEWS.md

@@ -11,7 +11,7 @@
 * `aspell_env_var()` does a better job of matching R CMD check behaviour,
   which is only to use `aspell`, not `hunspell` or `ispell` (#2376).
 
-* Installing devtools now installs pkgdown, profvis, bench, miniUI, DT, 
+* Installing devtools now installs pkgdown, profvis, bench, miniUI,
   and urlchecker, ensuring that you have everything needed for package
   development (#2388).
 

R/devtools-package.R

@@ -32,5 +32,8 @@
 
 ## usethis namespace: start
 #' @importFrom lifecycle deprecated
+#' @importFrom miniUI miniPage
+#' @importFrom profvis profvis
+#' @importFrom urlchecker url_check
 ## usethis namespace: end
 NULL

inst/WORDLIST

@@ -176,3 +176,7 @@ withr
 wordlists
 xyz
 yml
+miniUI
+ORCID
+profvis
+urlchecker

tests/testthat/test-reload.R

@@ -2,6 +2,7 @@ test_that("reload works", {
   withr::local_temp_libpaths()
 
   pkg <- as.package(test_path("testTest"))
+  pkg_name <- pkg$package
 
   install(pkg, quiet = TRUE)
   on.exit(unload(pkg$package), add = TRUE)
@@ -13,14 +14,14 @@ test_that("reload works", {
   expect_false(is_loaded(pkg))
 
   # Reload if loaded
-  requireNamespace(pkg$package, quietly = TRUE)
+  requireNamespace(pkg_name, quietly = TRUE)
   expect_true(is_loaded(pkg))
   reload(pkg, quiet = TRUE)
   expect_true(is_loaded(pkg))
 
   # Re-attach if attached
   unload(pkg$package, quiet = TRUE)
-  library(pkg$package, character.only = TRUE, quietly = TRUE)
+  library(pkg_name, character.only = TRUE, quietly = TRUE)
   expect_true(is_loaded(pkg))
   expect_true(is_attached(pkg))
   reload(pkg, quiet = TRUE)