fix(release): prevent stale tag publication - #77
Merged
Conversation
rabii-chaarani
force-pushed
the
codex/fix-release-publication-gate
branch
from
August 17, 2026 00:59
475a0bc to
6fb5511
Compare
rabii-chaarani
marked this pull request as ready for review
August 17, 2026 01:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- classify trusted release-please merges before allowing tag and GitHub Release creation\n- keep ordinary successful main CI runs limited to creating or updating the release PR\n- replace negated dry-run publisher conditions with an affirmative publish-assets authorization\n- preserve exact workflow-run, current-main-tip, and release-tag SHA validation\n- extend typed workflow policy tests and release documentation\n\n## Root causes\n1. Run 31980750823 followed an ordinary main CI completion while an older release PR was still pending. release-please created v1.4.1 at an older SHA before the existing post-action SHA guard could stop publication.\n2. Run 31982799005 validated the v1.4.2 artifacts, but both publisher jobs were silently skipped because publication depended on a negated string comparison against the dry-run output.\n\n## Verification\n- cargo test -p xtask --locked\n- cargo run -p xtask --locked -- check-workflows\n- cargo run -p xtask --locked -- release-gate\n- cargo clippy -p xtask --all-targets --locked -- -D warnings\n- cargo fmt --check\n- git diff --check\n- independent code review: approved with no high or critical findings\n\nactionlint was unavailable locally; the workflow parsed and passed the repository's typed YAML policy suite.