Add displacement prop to Radiant Lines starfield - #20
Conversation
Restore frame-rate independent star travel after the dt fix collapsed streaks into filled heads, and expose a displacement prop so scroll warp distance (and streak length) can be tuned. Co-authored-by: Jay Sharma <radiumcoders@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughRadiant Lines now supports a configurable ChangesRadiant Lines displacement
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized change adds configurable star displacement and updates its wrappers and documentation; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Demo
participant RadiantLines
participant createRadiantLines
participant AnimationEngine
Demo->>RadiantLines: set displacement
RadiantLines->>createRadiantLines: initialize with displacement
createRadiantLines->>AnimationEngine: configure displacement
AnimationEngine->>AnimationEngine: scale travel and trail depth
Demo->>RadiantLines: update displacement
RadiantLines->>AnimationEngine: setOptions displacement
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@cursoragent can u deploy this as preview |
|
Preview deploy is running for PR #20. I merged the Cloudflare PR preview workflow from main into this branch and pushed; GitHub Actions is uploading a Worker version (not production). The stable preview will be: https://pr-20-23rd-dev.radiumcoders.workers.dev Waiting for that Actions run to finish and post the URL on the PR. Production at 23rd.dev is unchanged. |
Co-authored-by: Jay Sharma <radiumcoders@gmail.com>
|
Cloudflare preview is ready.
Production (23rd.dev) is unchanged. This preview URL stays the same as you push to this PR. |


After the frame-rate (
dt) correction, star travel collapsed so the filled heads had almost no streaks. This restores 60fps-equivalent motion and adds adisplacementprop that scales how far each star jumps when warping (idle drift and scroll).Changes
displacementoption on the vanilla engine (default1)warp * 2.4 * 60 * dt * displacement, matching the original 60fps feelUsage
Summary by CodeRabbit
New Features
Bug Fixes
Documentation