Fix Threejs cube programming logos#4
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes missing/blank programming logos on the Three.js skill cube by changing how face textures are created for SVG icons that lack intrinsic dimensions.
Changes:
- Replaces
TextureLoaderface maps with aCanvasTexturepipeline that rasterizes SVG/raster icons onto an offscreen canvas. - Adds CORS handling via
Image.crossOrigin = "anonymous"and keeps face materials white to preserve native logo brightness.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Rasterize any image URL (SVG or raster) into a fixed-size offscreen | ||
| * canvas, then wrap it as a CanvasTexture. This bypasses THREE.js's | ||
| * default TextureLoader path, which loads via an internal | ||
| * HTMLImageElement — and which silently produces a zero-size texture |
| const dh = ih * scale | ||
| ctx.drawImage(img, (TEX_SIZE - dw) / 2, (TEX_SIZE - dh) / 2, dw, dh) | ||
| } else { | ||
| // SVG reported zero intrinsic size — fill the target square |
Comment on lines
+66
to
+70
| useEffect(() => { | ||
| const el = mountRef.current | ||
| if (!el) return | ||
| // Wipe any previous canvas (Fast Refresh / StrictMode remounts). | ||
| el.innerHTML = "" |
Comment on lines
+139
to
+142
| img.onload = () => { | ||
| const pad = TEX_SIZE * PAD_RATIO | ||
| const target = TEX_SIZE - pad * 2 | ||
| ctx.clearRect(0, 0, TEX_SIZE, TEX_SIZE) |
Comment on lines
+171
to
+175
| img.onerror = () => { | ||
| // Leave the face white — the accent glow still frames the cube. | ||
| // Log for diagnosis; the console will make failures obvious. | ||
| console.warn(`[SkillCube] Failed to load icon: ${iconUrl}`) | ||
| } |
Comment on lines
+238
to
+240
| return () => { | ||
| cancelAnimationFrame(rafId) | ||
| controls.dispose() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.