[5.x] Support multiple categories in indexer#1320
Open
Jade-GG wants to merge 2 commits into
Open
Conversation
royduin
reviewed
Jul 8, 2026
|
|
||
| $categories = $this->categoryProducts | ||
| ->where('category_id', '!=', config('rapidez.root_category_id')) | ||
| ->pluck('category') |
Member
There was a problem hiding this comment.
Do we really need the whole category? We do have all the category info here:
core/src/Models/Traits/Product/Searchable.php
Line 135 in 11cc749
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was written wrong, using
breadcrumbCategorieswhich only uses the longest path. I've added an attribute that can be used to get the same data in a collection from not just the longest path. Flattening this gives us the same data in the indexer, but then for all categories.