X-ORG-722: Publish API docs to docs.nvidia.com - #724
Conversation
ncclementi
left a comment
ncclementi
left a comment
There was a problem hiding this comment.
This looks pretty good, before merging, We have a question regarding the where the final url would land.
The deployment docs, go beyond the scope of datascience, it would be great to know if this is modifiable or not. See comment in line
| target-aws-secret-access-key: ${{ secrets.NVIDIA_DOCS_AWS_SECRET_ACCESS_KEY }} | ||
| target-s3-bucket: ${{ secrets.NVIDIA_DOCS_S3_BUCKET }} | ||
| target-s3-key-suffix: ${{ steps.set-version.outputs.VERSION }} # stable or nightly | ||
| target-s3-key: datascience/deployment |
There was a problem hiding this comment.
I'm not sure we necessarily fall under datascience. Does this target s3 key, maps to what the final url would be?
If yes, @josephine-wolf-oberholtzer do we get to choose this, or not at all?
@mmccarty Do you have any input here?
There was a problem hiding this comment.
We did discuss that the deployment docs should go under /datascience/deploy. While it is modifiable, where do you propose it should be?
There was a problem hiding this comment.
- Yes, the S3 key maps to the final URL AFAIUI.
datasciencewas the suggested naming convention from Alex. Let's take this to the migration project channel for hashing out? #swrapids-nvidia-migration.
|
After discussion, it seem like |
|
I'll have to come back to this - need to be able to run it in a CI container for the action to work. |
3 participants
Closes #722
Let's publish these docs to https://docs.nvidia.com/datascience/deployment.