added new Brev launchable instructions - #733
Conversation
ncclementi
left a comment
ncclementi
left a comment
There was a problem hiding this comment.
Looks pretty good. I think the docker compose should be self contained. like the equivalent to launching things via UI.
| # Remove this entry if you are not adding a repository. | ||
| - /home/ubuntu/<name_of_your_github_repo>:/home/rapids/notebooks/<name_of_your_github_repo> | ||
| user: root | ||
| command: jupyter-lab --notebook-dir=/home/rapids/notebooks --ip=0.0.0.0 --no-browser --allow-root --NotebookApp.token='' --NotebookApp.allow_origin='*' |
There was a problem hiding this comment.
I understand the 0.0.0.0 but I'm not sure if that's secure enough. Should we ask the Brev team about this?
There was a problem hiding this comment.
We can ask them about this yes, but while debugging I couldn't find a way to make the 127.0.0.1 work. I even tried without the --NotebookApp.token=' ' which disables authentication. We can ask the Brev team about how internet access/firewall rules are setup
| count: all | ||
| capabilities: [gpu] | ||
| environment: | ||
| - EXTRA_CONDA_PACKAGES # Value comes from a launch parameter of the same name |
There was a problem hiding this comment.
If we give put thsi as an example, don't we need : and some packages to show teh exmaple?
I'm worried this dockerfile won't work as is.
There was a problem hiding this comment.
We don't need it, as this variable is populated from the value from the Launch Parameters section. I added hdbscan and umap in launch parameters and I could import those packages in the Notebooks
| volumes: | ||
| # Repo cloned by the Source section, mounted alongside the example notebooks. | ||
| # Remove this entry if you are not adding a repository. | ||
| - /home/ubuntu/<name_of_your_github_repo>:/home/rapids/notebooks/<name_of_your_github_repo> |
There was a problem hiding this comment.
I assume we remove this to mount the whole repo and not map it to the notebooks directory right? Just wanted to make sure
There was a problem hiding this comment.
The reason for doing this was to keep the example notebooks visible to the user. If we map to the notebooks directory, users can see the cudf, cugraph, cuml examples folders along with the cloned repo added as the fourth folder in the root of the mounted path
|
|
||
| ```yaml | ||
| environment: | ||
| - EXTRA_CONDA_PACKAGES |
There was a problem hiding this comment.
Have you checked once the instance is launched if the extra packages installed work?
To see if they were properly installed?
There was a problem hiding this comment.
Yep I could import them into the notebook without any errors.
ncclementi
left a comment
ncclementi
left a comment
There was a problem hiding this comment.
pending understanding on the 0.0.0.0 change.
|
Confirmed with the Brev team that they switched from using Cloudflare for secure links to an internal tool called Skybridge which only supports external access through the |
2 participants
Updates the Brev launchable instructions to reflect the new UI changes on Brev.
While testing this out, I also found a few bugs and made some changes in the old Docker Compose YAML file:
backend(now renamed tojupyter) was not nested under services and was failing YAML parsing--ip=127.0.0.1changed to--ip=0.0.0.0. I could not reach the earlier Jupyter endpoint over the internet and this configuration change worked--notebook-dir=/notebooks. This was showing up in Jupyterlab as an empty folder and not with the examples as intendedEXTRA_CONDA_PACKAGESis now a launch configuration variable with the value being passed to the container. This way users can customize their packages at deploy time rather than the Launchable creation timeI added screenshots of every single section, and tested everything out end to end. This new configuration ensures a healthy Jupyterlab, with access to any cloned repositories and all of the example notebooks.