Add structured, physical read traces - #1016
Open
TomAugspurger wants to merge 4 commits into
Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 19db970 |
Contributor
Author
|
/ok to test 908041a |
TomAugspurger
marked this pull request as ready for review
July 29, 2026 17:17
TomAugspurger
commented
Jul 29, 2026
Contributor
Author
There was a problem hiding this comment.
This is deliberately private. It's been useful for me, and might be useful for others, but I don't think we should commit to maintaining it.
|
|
||
| {"event":"read","level":"trace","source":"s3://bucket/data.parquet","start":1747901139123456789,"end":1747901139127890123,"offset":4194304,"size":1048576,"threadId":17390204170953158183,"bytesRead":1048576,"backend":"remote","status":"ok","isDeviceBuffer":true,"requestId":42,"method":"GET"} | ||
|
|
||
| HTTP metadata JSON objects have ``"event":"http"`` and the following fields: |
Contributor
Author
There was a problem hiding this comment.
I wonder if this should just go under event: read with method: HEAD. Why split it out into its own thing?
Contributor
Author
|
This will need to be benchmarked to see how much overhead we've introduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our logging setup to optionally emit structured, physical traces.
There are two main sets of changes:
TRACElevel. This takes the "logical" reads from the user's program and traces the actual reads done by kvikio, which might be smaller thanks to kvikio's read splittingHere's an example program:
When run with
KVIKIO_LOG_LEVEL=TRACE KVIKIO_LOG_FORMAT=JSON KVIKIO_LOG_FILE=trace.ndjson python test_remote.pythat writesCloses #967