fix(data-gen): build only the tpchgen-cli Rust stage - #402
Open
Avinash-Raj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_tpchgen_cli.shclones TomAugspurger/tpchgen-rs anddocker builds the upstream Dockerfile, then copies only/usr/local/bin/tpchgen-cliout of the image.That Dockerfile is multi-stage. The builder stage compiles the Rust CLI. A later python-deps stage runs
uv pip install pyarrow(~48 MiB wheel) with UV_HTTP_TIMEOUT=30s. CI often cannot finish that download/extract, so the whole install fails even though we never use pyarrow or the Python entrypoint.This change builds
--target builderso Cargo still producestpchgen-cliand thepyarrowinstall is skipped.Why?
Our CI runner job (https://github.com/rapidsai/velox-testing/actions/runs/32334525240/job/96331784081) sometimes faces network failures when building the unnecessary python-deps stage. This PR restricts Docker to build only the necessary stage (builder) instead of all stages such as builder, python-deps, etc., since we only need the binary built from the builder stage.