vcgencmd: Make use of more restricted vcio_gencmd node if available#178
Merged
pelwell merged 1 commit intoraspberrypi:masterfrom May 11, 2026
Merged
vcgencmd: Make use of more restricted vcio_gencmd node if available#178pelwell merged 1 commit intoraspberrypi:masterfrom
pelwell merged 1 commit intoraspberrypi:masterfrom
Conversation
timg236
approved these changes
May 8, 2026
pelwell
reviewed
May 11, 2026
| } | ||
| return file_desc; | ||
| printf("Can't open device file: %s\n", devices[0]); | ||
| printf("Try creating a device file with: sudo mknod %s c %d 0\n", devices[0], MAJOR_NUM); |
Collaborator
There was a problem hiding this comment.
The suggested mknod line is now even more outdated than it was before. The misc devices all have a major if 10, and with dynamic minor allocation, you can't know which numbers to put in here - delete this line.
| #define DEVICE_FILE_NAME "/dev/vcio" | ||
| #define countof(x) (sizeof x/sizeof *x) | ||
|
|
||
| #define MAJOR_NUM 100 |
Collaborator
There was a problem hiding this comment.
It's better to refer to this as a magic number - the kernel driver calls it VCIO_IOC_MAGIC - since it is now divorced from the device major number.
Contributor
Author
|
@pelwell updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: raspberrypi/linux#7351