Skip to content

Added compatibility to PHP 8.5 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-koebsch merged 3 commits into from
Jun 9, 2026
Merged

Added compatibility to PHP 8.5 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
389a5bc
Added compatibility to PHP 8.5
FatchipRobert Jun 9, 2026
65cb86b
Revert "Added compatibility to PHP 8.5"
FatchipRobert Jun 9, 2026
d237552
Added compatibility to PHP 8.5
FatchipRobert Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Model/Response/AbstractResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,10 @@ abstract class AbstractResponse

/**
* AbstractResponse constructor. Sets response.
*
* @param \SimpleXmlElement $response
*/
public function __construct(\SimpleXmlElement $response = null)
public function __construct($response = null)
{
if ($response !== null) {
if ($response !== null && $response instanceof \SimpleXmlElement) {
$this->setResponse($response);

$this->setStatusCode((string) $this->getResponse()->head->processing->status->attributes()->code);
Expand Down
6 changes: 4 additions & 2 deletions src/Service/CommunicationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,10 @@ public function send($xml, $connectionTimeout = 0, $executionTimeout = 0, $retri

$statusCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);

// close connection
curl_close($ch);
if (version_compare(PHP_VERSION, '8.0.0', '<')) { // curl_close does nothing since 8.0 and is deprecated since 8.5
// close connection
curl_close($ch);
}

// status codes 3xx and 5xx are not processable by the SDK (we assume that the body will be invalid too)
$invalidStatusCode = $statusCode < 200 || ($statusCode >= 300 && ($statusCode < 400 || $statusCode >= 500));
Expand Down
Loading