Fix reviewer Slack lookup in notify-pr-review workflow - #51
Merged
Conversation
yq v4 has no --arg flag, so the lookup exited 1 and failed the job for every review event. Use strenv() with the login from the environment. Co-Authored-By: brandon <brandon@flightcontrol.dev>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
notifyjob fails on every review event: the reviewer→Slack lookup used jq's--argflag, which yq v4 doesn't have, so yq printed its help and exited 1 underset -euo pipefail.Verified with yq v4 against this repo's
.github/reviewer-slack-map.yml: a mapped login returns its Slack ID, an unmapped login returns empty (hits the existing skip-with-warning path). Also dropped the leftoveryq --versiondebug line. Same fix as ravionhq/modules#110.Link to Devin session: https://app.devin.ai/sessions/a842d7a1edaa4ad0b9b9908ddd403217
Requested by: @flybayer
Greptile Summary
Fixes reviewer-to-Slack lookup in the PR review notification workflow by replacing unsupported
yq --argusage with yq v4’sstrenvlookup.map_filevariable for the reviewer mapping path.Confidence Score: 5/5
The PR appears safe to merge with no actionable defects identified.
The changed lookup uses syntax supported by the workflow runner’s yq implementation, receives the reviewer login through the environment, and preserves both mapped and unmapped lookup behavior.
Important Files Changed
Reviews (1): Last reviewed commit: "Fix reviewer Slack lookup in notify work..." | Re-trigger Greptile