Skip to content

Fix reviewer Slack lookup in notify-pr-review workflow - #51

Merged
flybayer merged 1 commit into
mainfrom
devin/1786481889-fix-notify-yq
Aug 11, 2026
Merged

Fix reviewer Slack lookup in notify-pr-review workflow#51
flybayer merged 1 commit into
mainfrom
devin/1786481889-fix-notify-yq

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

The notify job fails on every review event: the reviewer→Slack lookup used jq's --arg flag, which yq v4 doesn't have, so yq printed its help and exited 1 under set -euo pipefail.

-slack_channel="$(yq -r --arg login "${login}" '.[$login] // ""' .github/reviewer-slack-map.yml)"
+slack_channel="$(login="${login}" yq -r '.[strenv(login)] // ""' "${map_file}")"

Verified with yq v4 against this repo's .github/reviewer-slack-map.yml: a mapped login returns its Slack ID, an unmapped login returns empty (hits the existing skip-with-warning path). Also dropped the leftover yq --version debug line. Same fix as ravionhq/modules#110.

Link to Devin session: https://app.devin.ai/sessions/a842d7a1edaa4ad0b9b9908ddd403217
Requested by: @flybayer

Greptile Summary

Fixes reviewer-to-Slack lookup in the PR review notification workflow by replacing unsupported yq --arg usage with yq v4’s strenv lookup.

  • Uses the existing map_file variable for the reviewer mapping path.
  • Removes the leftover yq version diagnostic.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changed lookup uses syntax supported by the workflow runner’s yq implementation, receives the reviewer login through the environment, and preserves both mapped and unmapped lookup behavior.

Important Files Changed

Filename Overview
.github/workflows/notify-pr-review.yml The revised yq v4 expression correctly resolves mapped reviewer logins while preserving the existing warning-and-skip behavior for unmapped reviewers.

Reviews (1): Last reviewed commit: "Fix reviewer Slack lookup in notify work..." | Re-trigger Greptile

yq v4 has no --arg flag, so the lookup exited 1 and failed the job for
every review event. Use strenv() with the login from the environment.

Co-Authored-By: brandon <brandon@flightcontrol.dev>
@flybayer flybayer self-assigned this Aug 11, 2026
@mintlify

mintlify Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Ravion 🟢 Ready View Preview Aug 11, 2026, 9:00 PM

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@flybayer
flybayer merged commit 64e0307 into main Aug 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant