Skip to content

Adding range to tags#524

Open
kkrime wants to merge 4 commits into
ray-x:masterfrom
kkrime:adding_range_to_tags
Open

Adding range to tags#524
kkrime wants to merge 4 commits into
ray-x:masterfrom
kkrime:adding_range_to_tags

Conversation

@kkrime

@kkrime kkrime commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

Adding range to the :Go.*Tag commands

@ray-x I'm not sure I understand the :GoModifyTag command, it's not in the documentation, do we really need it?

@kkrime kkrime marked this pull request as ready for review November 21, 2024 04:06
@kkrime

kkrime commented Nov 21, 2024

Copy link
Copy Markdown
Contributor Author

@ray-x I'll fix the tests, but before I do so, can you let me know what you think about the changes I've made?

@ray-x

ray-x commented Dec 1, 2024

Copy link
Copy Markdown
Owner

Thanks for the PR
Could you check the action errors lua/go/tags.lua:114: attempt to index local 'opts' (a nil value) ?

@kkrime

kkrime commented Dec 7, 2024

Copy link
Copy Markdown
Contributor Author

I'm having trouble running the git hub actions locally using act

@ray-x are you able to run the github actions locally and if so what type of machien are you using??
(I'm using osx on m1)

@ray-x

ray-x commented Jan 27, 2025

Copy link
Copy Markdown
Owner

Sorry for the late reply.
To run tests locally, you can use makefile:
https://github.com/ray-x/go.nvim/blob/5308b3eb07640d5aff28461048179552b7b7d015/Makefile#L11C1-L12C102

In your case, the go_tags_spec failed
you can update the Makefile and adding

localtesttags: localtestsetup
	nvim --headless --noplugin -u lua/tests/init.vim -c "PlenaryBustedFile lua/tests/go_tags_spec.lua"

and then run make localtesttags

The reason test failed is the test is calling tags.add() directly without arguments while in the changes you made, the opt is a must parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants