RDKB-66116 : use freedesktop dbus-1.14 and gate native-build/CodeQL by source paths

[pavankumar464]

Reason for change: Address PRs native builds failing in the javascript-templates

Test Procedure: PRs native builds should pass for javascript-templates

Risks: Low

Priority: P2

[Copilot]

Pull request overview

Updates the dbus external dependency reference used by the native build/Coverity docker workflow to a specific Deepin branch, with the goal of fixing PR native build failures.

Changes:

• Pin dbus dependency from master to 1.14.10-3-1deepin3 in the component configuration.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

cov_docker_script/component_config.json:79

• Inconsistent JSON formatting: other entries use "branch": without a space before the colon. Since this line is being changed anyway, please align it for consistency.

        "branch" : "dbus-1.14",

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

.github/workflows/native-build.yml:63

• The PR build is gated on has_component, but the component filter only matches source/**/*. Changes to build inputs like cov_docker_script/component_config.json (this PR) or workflow/build scripts will set has_component to false and skip the native build on pull requests, preventing CI from validating these changes.

          filters: |
            component:
              - 'source/**/*'
            cpp:

.github/workflows/native-build.yml:45

• The PR title/description indicates this change is only about switching the dbus repo/branch, but this workflow also adds CodeQL scanning and new PR build gating logic. Please update the PR description to reflect these additional CI/analysis changes so reviewers understand the full scope.

  detect-source-changes:
    name: Detect source path changes for CodeQL
    runs-on: ubuntu-latest

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

.github/workflows/native-build.yml:63

• component change filter is too narrow: PRs that only touch build configuration/scripts (e.g. cov_docker_script/component_config.json) will set has_component to false, skipping the native build job even though the build behavior changed. Include the build config/script paths (and optionally this workflow) in the component filter so the build still runs when its inputs change.

            component:
              - 'source/**/*'

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

.github/workflows/native-build.yml:89

• build-jst-on-pr is gated by has_component, but the component filter only matches source/**/*. That means PRs that change build-critical files (e.g., CMakeLists.txt, configure.ac, cov_docker_script/component_config.json, or this workflow) will skip the native build, reducing CI coverage and making it easy to merge build-breaking changes.

            component:
              - 'source/**/*'

.github/workflows/native-build.yml:202

• The JS paths filter includes tests/**/*.js, but the CodeQL JS config limits analysis to tests/parser. This can run the job for changes it won’t actually analyze. Align the analyzed paths with the filter (e.g., include tests).

            paths:
              - source
              - jsts
              - tests/parser

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/native-build.yml:89

• paths-filter's component filter only matches source/**/*, so build-jst-on-pr will be skipped for PRs that change other build-relevant paths (e.g. jsts/**, top-level CMakeLists.txt, or build/config scripts like cov_docker_script/**). In this PR, only cov_docker_script/component_config.json + the workflow change, so the PR build job would not run.

            component:
              - 'source/**/*'

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/native-build.yml:90

• build-jst-on-pr is gated by has_component, but the component paths-filter only watches source/**/*. This PR changes cov_docker_script/component_config.json, which would not trigger the native build on PRs—so dependency/build-script changes won’t be validated and can still break native builds.

            component:
              - 'source/**/*'
            cpp:

.github/workflows/native-build.yml:136

• The CodeQL C/C++ job updates submodules without --remote, while the native build jobs use --remote. This makes the build toolchain version differ between jobs and can lead to CodeQL building/analyzing a different dependency set than the native build CI.

        run: |
          git config --global --add safe.directory '*'
          git submodule update --init --recursive
          chmod +x build_tools_workflows/cov_docker_script/setup_dependencies.sh

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/native-build.yml:90

• build-jst-on-pr is gated by has_component, but the component paths-filter only matches source/**/*. That means PRs that change build inputs like cov_docker_script/component_config.json (this PR) will skip the native build job entirely, so the change won't be validated in CI. Expand the component filter to include the build/config paths that affect the native build.

            component:
              - 'source/**/*'
            cpp:

.github/workflows/native-build.yml:140

• The CodeQL C/C++ build uses git submodule update --init --recursive while the native build jobs use --remote. This can make the CodeQL build analyze a different dependency set than the native build (or vice-versa), reducing signal and making failures harder to reproduce. Consider aligning these flags (or adding a short comment explaining why they intentionally differ).

      - name: Build component for CodeQL
        run: |
          git config --global --add safe.directory '*'
          git submodule update --init --recursive
          chmod +x build_tools_workflows/cov_docker_script/setup_dependencies.sh

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (3)

.github/workflows/native-build.yml:90

• build-jst-on-pr is gated by has_component, but the component filter only matches source/**/*. That means PRs that only change build/dependency inputs (e.g. cov_docker_script/component_config.json in this PR, or root build files) will skip the native build entirely, which defeats the goal of validating build fixes on PRs. Expand the component filter to include build/dependency paths that affect the native build.

            component:
              - 'source/**/*'
            cpp:

.github/workflows/native-build.yml:69

• Job name says this is only for CodeQL, but its outputs also gate the PR native build job (build-jst-on-pr). Renaming avoids confusion when reading workflow logs and job dependencies.

    name: Detect source path changes for CodeQL

.github/workflows/native-build.yml:144

• The native build jobs update submodules with --remote, but the CodeQL C/C++ build uses git submodule update --init --recursive without --remote. This can make CodeQL build against a different build-tools revision than the native build job, potentially reintroducing build failures or producing inconsistent results. Consider aligning the submodule update mode.

          git config --global --add safe.directory '*'
          git submodule update --init --recursive
          chmod +x build_tools_workflows/cov_docker_script/setup_dependencies.sh

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/native-build.yml:90

• build-jst-on-pr is gated by has_component, but the component filter only matches source/**/*. That means PRs that change the native build inputs (e.g., cov_docker_script/component_config.json in this PR, or build_tools_workflows/**) will skip the PR native build entirely, making it easy to merge broken build/dependency changes.

            component:
              - 'source/**/*'

.github/workflows/native-build.yml:31

• git submodule update --remote makes CI builds non-reproducible (it can pull newer submodule commits than the ones reviewed in this PR) and can cause intermittent failures if the submodule’s tracked branch moves. Prefer using the pinned submodule commit unless there’s a strong reason to float.

          git submodule update --init --recursive --remote