STBT-56052: Remove setscene support from staging-ipk-pkgs - #108
Open
thellef wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes setscene support from the staging-ipk-pkgs recipe and its associated staging-ipk bbclass to address build problems caused by cached IPK packages that could not be invalidated, preventing dependency updates. By eliminating the setscene function, the build system will always execute the task normally, allowing for proper dependency updates.
- Increments the PR variable in
staging-ipk-pkgs.bbto force recipe rebuild - Removes the
do_populate_ipk_sysroot_setscenePython function that invoked shared state caching - Adds a new
do_ipk_sysroot_cleanshell task to clean IPK directories during the clean phase
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| recipes-core/staging-ipk-pkgs.bb | Increments PR to "r1" to force rebuild after removing setscene support |
| classes/staging-ipk.bbclass | Replaces the setscene function with a clean task that removes IPK staging directories before the clean phase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The setscene function has caused many build problems because it can never invalidate the cached IPK packages, so we can never get new dependencies downloaded or installed. By not having the setscene function we can update dependencies. Change-Id: Ic7c9e2f913fc4f23b3706c77635dd8fb696d0820
thellef
force-pushed
the
topic/no-setscene
branch
from
December 9, 2025 15:56
3464220 to
35bd515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setscene function has caused many build problems because it can never invalidate the cached IPK packages, so we can never get new dependencies downloaded or installed.
By not having the setscene function we can update dependencies.