RDKEMW-23008: Fix remaining coverity issues

[trupthi1403]

Reason for change: Added fix for use-after-free issues
Test procedure: As in ticket
Risks: Medium

[Copilot]

Pull request overview

This PR targets remaining Coverity findings by adjusting GStreamer property access patterns and session handling to mitigate reported use-after-free and copy/move issues in the middleware player interface.

Changes:

• Updated GStreamer decryptor property assignment to set multiple pointer properties in a single g_object_set() call.
• Consolidated decoder dimension reads into a single g_object_get() call and adjusted logging pointer usage.
• Modified DrmSessionManager local session handling (currently switching from copy to reference).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
vendor/SocInterface.cpp	Adjusts warning log when plugin scan yields default platform.
InterfacePlayerRDK.cpp	Updates decryptor property assignment to use g_object_set() with multiple properties.
externals/PlayerExternalsInterfaceBase.h	Consolidates video_height/video_width reads and updates log pointer reference.
drm/DrmSessionManager.cpp	Changes local session variable from copy to reference across several methods.

Suppressed comments (4)

drm/DrmSessionManager.cpp:244

• Using a const reference does not create the “local copy” described in the comment and does not extend the session lifetime; ContentSecurityManagerSession is explicitly designed to be copied (shared ownership) to keep the session open while using its ID. Use a copy here.

	const auto& localSession = mContentSecurityManagerSession; //Remove potential isSessionValid(), getSessionID() race by using a local copy

drm/DrmSessionManager.cpp:264

• Using a const reference does not create the “local copy” described in the comment and does not extend the session lifetime; ContentSecurityManagerSession is explicitly designed to be copied (shared ownership) to keep the session open while using its ID. Use a copy here.

	const auto& localSession = mContentSecurityManagerSession; //Remove potential isSessionValid(), getSessionID() race by using a local copy

drm/DrmSessionManager.cpp:276

• Using a const reference does not create the “local copy” described in the comment and does not extend the session lifetime; ContentSecurityManagerSession is explicitly designed to be copied (shared ownership) to keep the session open while using its ID. Use a copy here.

	const auto& localSession = mContentSecurityManagerSession; //Remove potential isSessionValid(), getSessionID() race by using a local copy

drm/DrmSessionManager.cpp:971

• Using a const reference does not create the “local copy” described in the comment and does not extend the session lifetime; ContentSecurityManagerSession is explicitly designed to be copied (shared ownership) to keep the session open while using its ID. Use a copy here.

	const auto& localSession = mContentSecurityManagerSession; //Remove potential isSessionValid(), getSessionID() race by using a local copy

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.