RDKEMW-23361 : Failed to Connect to Hidden SSID

[jincysam87]

Reason for change: wifi connect call with invalid/hidden SSID results in IPC timeout
Test Procedure: Issue wifi connect does not timeout even if SSID is invalid/hidden
Risks: Medium

Signed-off-by: jincysaramma_sam@cable.comcast.com

[Copilot]

Pull request overview

This PR aims to prevent WiFi connect IPC timeouts when attempting to connect to an invalid/hidden SSID by adjusting the connection flow when the SSID is not found in the scan list.

Changes:

• Adds a deleteClientConnection() call before attempting to persist and connect to a hidden/unknown SSID via addToKnownSSIDs().

Suppressed comments (1)

plugin/gnome/NetworkManagerGnomeWIFI.cpp:1193

• In this branch, deleteClientConnection() is now called before addToKnownSSIDs(), but the code still calls deleteClientConnection() again on both success and failure paths. Since addToKnownSSIDs() creates and deletes its own client connection, these extra calls will pop an unpushed GMainContext and unlock m_opMutex when it is not held, which is undefined behavior and can crash/hang.

                    deleteClientConnection();
                    if(addToKnownSSIDs(ssidInfo))
                    {
                        NMLOG_DEBUG("Adding to known ssid '%s' ", ssidInfo.ssid.c_str());
                        deleteClientConnection();

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.