Apprt-947-Getting the Error while try to build the refui bolt package - #240
Apprt-947-Getting the Error while try to build the refui bolt package#240SudarsananComcast wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the RefUI package/application version to 6.0.33 and adjusts the Bolt packaging script to address a build-time dependency issue when producing the RefUI Bolt package.
Changes:
- Bump RefUI version strings from 6.0.31 to 6.0.33 in Bolt package metadata and UI settings.
- Update
bolt/pack.shto install a pinned TypeScript version to satisfy@lightningjs/cliduringlng dist.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bolt/package-configs/com.rdkcentral.refui.json | Bumps Bolt package version / versionName to 6.0.33. |
| bolt/pack.sh | Adds an npm install step intended to unblock lng dist builds (but currently uses a brittle hard-coded global path). |
| accelerator-home-ui/settings.json | Bumps UI platformSettings.version to 6.0.33. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| npm install -g @lightningjs/cli | ||
|
|
||
| npm install --prefix /usr/local/lib/node_modules/@lightningjs/cli typescript@5.2.2 --no-save | ||
|
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
accelerator-home-ui/package.json:12
typescriptis added as a runtime dependency, but there are no.tssources/tsconfig in this package; it appears to be needed only for build tooling. Consider moving it todevDependenciesand updatingpackage-lock.jsonaccordingly (otherwisenpm ciwill fail due to package.json/lock mismatch).
"dependencies": {
"@hendt/xml2json": "^1.0.3",
"@lightningjs/sdk": "^4.8.1",
"@lightningjs/ui": "^1.3.7",
"@lightningjs/ui-components": "^2.2.1",
"typescript": "5.2.2",
"redux": "^4.2.1",
"ThunderJS": "github:rdkcentral/ThunderJS"
},
bolt/pack.sh:32
pack.shinstalls@lightningjs/cliglobally withoutsudo, but then usessudoto install TypeScript into the CLI folder. This can leave the global CLI directory root-owned and break subsequent npm installs/runs for non-root users. Prefer installing with the same privileges (or switch to a local/npx-based CLI install).
npm install -g @lightningjs/cli
sudo npm install --prefix "$(npm root -g)/@lightningjs/cli" typescript@5.2.2 --no-save
lng dist
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
bolt/pack.sh:28
npxwithout--no-installcan implicitly download and execute a package from the registry if the locallngbinary is missing, which hurts reproducibility and increases supply-chain risk. Prefer invoking the locally installed binary directly (or usenpx --no-install).
npx lng dist
accelerator-home-ui/package.json:10
@lightningjs/cliandtypescriptare build-time tooling and (given this project has no.tsfiles/tsconfig) don't appear to be runtime dependencies. Consider moving them todevDependenciesto avoid shipping tooling in production installs (and document if they must remain independencies).
"@lightningjs/cli": "2.14.2",
"@lightningjs/sdk": "^4.8.1",
"@lightningjs/ui": "^1.3.7",
"@lightningjs/ui-components": "^2.2.1",
"typescript": "5.2.2",
| "description": "accelerator-home-ui", | ||
| "dependencies": { | ||
| "@hendt/xml2json": "^1.0.3", | ||
| "@lightningjs/cli": "2.14.2", |
No description provided.