gh25 - Make being unable to get image names from a registry a warning - #71
Merged
BenjiMilan merged 2 commits intoAug 19, 2026
Merged
Conversation
… instead of an error
There was a problem hiding this comment.
Pull request overview
Updates sc docker to tolerate failures from individual registries when listing available image names, aligning behavior with Issue #25 by continuing to operate with other registries instead of exiting.
Changes:
- Downgrades failure to fetch image names from a registry from a fatal error (
sys.exit(1)) to a warning and continues. - Returns an empty image list for the failing registry to allow aggregating results from other registries.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
BenjiMilan
deleted the
feature/gh25_all_docker_run_fails_when_any_registry_down
branch
August 19, 2026 10:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… instead of an error
Closes #25
sc docker is a bit of a mess. I'm going to split out DockerConfigManager & then wrap DockerClient as separate classes. So then ScDocker itself is just an orchestrator that also builds the docker command. But as separate PRs.