Skip to content

RDKBACCL-1962 RDKB- Security Vulnerability Findings Report in WebUI BPI #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanemage wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

RDKBACCL-1962 RDKB- Security Vulnerability Findings Report in WebUI BPI #148

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54aa50d
RDKBACCL-1962 RDKB- Security Vulnerability Findings Report in WebUI BPI
Aug 3, 2026
4e9b478
Revert "RDKBACCL-1962 RDKB- Security Vulnerability Findings Report i…
Aug 5, 2026
32a8a66
RDKBACCL-1962 Fix SSID security validation for BPI
Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 44 additions & 3 deletions source/Styles/xb6/jst/actionHandler/ajaxSet_wireless_network_configuration_onewifi.jst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,17 @@ function validChecksum($WPS_pin){
$accum += 1 * (intval($WPS_pin / 1) % 10);
return (0 == ($accum % 10));
}

function ResolveRadioFromSsid($ssid){
$ssid_tmp = String($ssid);
$ssid_lower_layers = String(getStr("Device.WiFi.SSID."+$ssid_tmp+".LowerLayers"));
LogStr(" : value of ssid_lower_layers" + $ssid_lower_layers);
if (preg_match('/Radio\\.1(\\.|$)/', $ssid_lower_layers) == 1) return 1;
if (preg_match('/Radio\\.2(\\.|$)/', $ssid_lower_layers) == 1) return 2;
if (preg_match('/Radio\\.3(\\.|$)/', $ssid_lower_layers) == 1) return 3;
return "";
}

function validFilterParam($ft){
for(var $keytmp in $ft) { $val=$ft[$keytmp];/*p2j-foreach*/
if(!(printableCharacters($val[0]) && validMAC($val[1]))) return false;
Expand All @@ -66,7 +77,21 @@ if ($_POST['configInfo']) {
//$jsConfig = '{"ssid_number":"1", "ft":[["1","2"],["c","d"]], "target":"save_filter"}';
$arConfig = json_decode($jsConfig, true);
//print_r($arConfig);
$i = $arConfig['ssid_number'];

$i = (array_key_exists('ssid_number', $arConfig)) ? String($arConfig['ssid_number']) : "";
$ssid_log = substr(String($i), 0, 32);
if ($i != "" && strlen($i) > 3) {
LogStr(" : security_event:invalid_ssid_number_length:" + String(strlen($i)) + " value_prefix:" + $ssid_log);
http_response_code(400);
echo( '{"error":"invalid_ssid_number"}');
exit(0);
}
if ($i != "" && preg_match("/^(?:[1-9]|1[0-9]|2[0-4])$/", $i) != 1) {
LogStr(" : security_event:invalid_ssid_number_format value_prefix:" + $ssid_log);
http_response_code(400);
echo( '{"error":"invalid_ssid_number"}');
exit(0);
}
if($i == "17")
{
$Radio_3_Enable = getStr("Device.WiFi.Radio.3.Enable");
Expand Down Expand Up @@ -115,8 +140,24 @@ else
if($i == 17)
$r=3; //17th is private ssid for 6 GHz(radio 3)
else
$r = $i;
$channel = getStr("Device.WiFi.Radio."+$r+".AutoChannelEnable");
$i = String($arConfig['ssid_number']);
$r = ResolveRadioFromSsid($i);
if ($r == "") {
LogStr(" : ResolvedSSid returned security_event:invalid_ssid_mapping ssid:" + substr(String($i), 0, 32));
http_response_code(400);
echo( '{"error":"invalid_ssid_mapping"}');
exit(0);
}
$get_channel_automatic = getStr("Device.WiFi.Radio."+$r+".AutoChannelEnable");
$get_wireless_mode = getStr("Device.WiFi.Radio."+$r+".OperatingStandards");
$get_channel_bandwidth = getStr("Device.WiFi.Radio."+$r+".OperatingChannelBandwidth");
function MiniApplySSID($ssid) {
$apply_rf = ResolveRadioFromSsid($ssid);
if ($apply_rf == "")
return;
setStr("Device.WiFi.Radio."+$apply_rf+".X_CISCO_COM_ApplySetting", "true", true);
}

if ("save_config" == $arConfig['target'])
{
//save_basic & save_advance is only for mso
Expand Down
Loading