Conversation
Summary: Self-register commands from the `community-cli-plugin` package via `react-native.config.js` — meaning we can remove the redirect within `packages/react-native/react-native.config.js`. Progress towards removing `community-cli-plugin` as a direct dep of `react-native`, and paired with react-native-community/template#235. Changelog: [General][Breaking] - `react-native/community-cli-plugin` will no longer be auto-detected from `react-native`. It must now be specified in `devDependencies`. Differential Revision: D109869538
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109869538. |
|
Hi @huntie! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary: Replaces #57352. Self-register commands from the `community-cli-plugin` package via `react-native.config.js` — meaning we can remove the redirect within `packages/react-native/react-native.config.js`. Progress towards removing `community-cli-plugin` as a direct dep of `react-native`, and paired with react-native-community/template#235. RNTester and HelloWorld list `react-native/community-cli-plugin` in `devDependencies`, as the template now does (react-native-community/template#235). Changelog: [General][Breaking] - `react-native/community-cli-plugin` will no longer be auto-detected from `react-native`. It must now be specified in `devDependencies`. Pull Request resolved: #58670 Test Plan: Compared `react-native config` output with `react-native-community/cli` 20.2.0. **RNTester** - ✅ Commands, platforms, and project config are unchanged from `main` - ✅ Removing the new `react-native/community-cli-plugin` devDependency drops `bundle`, `start`, `spm`, and `codegen`, so they are registered by plugin discovery **Template-shaped app** (plugin in `devDependencies`, no project `react-native.config.js`) - ✅ `bundle`, `start`, `spm`, and `codegen` are registered Reviewed By: christophpurrer, cortinico Differential Revision: D121634885 Pulled By: Abbondanzo fbshipit-source-id: e97c9f820d3c597233ef4a7ddaaf1b752f1f7688
2 participants
Summary:
Self-register commands from the
community-cli-pluginpackage viareact-native.config.js— meaning we can remove the redirect withinpackages/react-native/react-native.config.js.Progress towards removing
community-cli-pluginas a direct dep ofreact-native, and paired with react-native-community/template#235.Changelog:
[General][Breaking] -
@react-native/community-cli-pluginwill no longer be auto-detected fromreact-native. It must now be specified indevDependencies.Differential Revision: D109869538