Move multi-source image disk cache checks off the UI thread - #58701
Open
Abbondanzo wants to merge 2 commits into
Open
Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
…ct#58657) Summary: Programmatic list scrolling can move to an edge before asynchronously scheduled cells finish rendering. The scroll handler then skips the edge callback because the terminal cell is not yet in the render window, and no later scroll or layout event is guaranteed. Recheck edge callbacks after post-scroll render updates. Track the item count when an edge callback is sent so internal measurement changes cannot emit duplicates while the list remains at the same edge; appending data or scrolling away re-arms the callback. Changelog: [General][Fixed] - Fire `VirtualizedList` edge callbacks after programmatic scrolling Differential Revision: D100870075
Summary: Avoid synchronous disk I/O while Android selects a source for multi-source images. The best source and bitmap-memory-cache candidate are selected immediately, then Fresco's asynchronous disk-cache API finds the most precise cached source and upgrades the request when it completes. Both Android image-view implementations reject stale callbacks after a new request, source update, size change, or detach. The behavior remains behind a disabled-by-default runtime gate. Changelog: [Android][Fixed] - Avoid blocking the UI thread while selecting multi-source images Differential Revision: D122082126
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122082126. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Avoid synchronous disk I/O while Android selects a source for multi-source images. The best source and bitmap-memory-cache candidate are selected immediately, then Fresco's asynchronous disk-cache API finds the most precise cached source and upgrades the request when it completes.
Both Android image-view implementations reject stale callbacks after a new request, source update, size change, or detach. The behavior remains behind a disabled-by-default runtime gate.
Changelog:
[Android][Fixed] - Avoid blocking the UI thread while selecting multi-source images
Differential Revision: D122082126