Skip to content

fix: update analyze_comment body-includes - #5907

Closed
awxiaoxian2020 wants to merge 1 commit into
reactjs:mainfrom
awxiaoxian2020:patch-1
Closed

fix: update analyze_comment body-includes#5907
awxiaoxian2020 wants to merge 1 commit into
reactjs:mainfrom
awxiaoxian2020:patch-1

Conversation

@awxiaoxian2020

Copy link
Copy Markdown
Contributor

We can see https://github.com/reactjs/react.dev/actions/runs/4654784574/jobs/8236816631#step:6:13
It has updated to <!-- __NEXTJS_BUNDLE_react-dev -->

@github-actions

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@awxiaoxian2020

Copy link
Copy Markdown
Contributor Author

@gaearon Could you please consider this PR?

@gaearon

gaearon commented Apr 28, 2023

Copy link
Copy Markdown
Member

Interesting. I guess we picked up hashicorp/nextjs-bundle-analysis#44 accidentally because our workflow always gets the latest version.

@gaearon

gaearon commented Apr 28, 2023

Copy link
Copy Markdown
Member

Thanks. I fixed it via #5971 + 496c578 instead.

@gaearon gaearon closed this Apr 28, 2023
@awxiaoxian2020
awxiaoxian2020 deleted the patch-1 branch April 29, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants