RHDHBUGS-3057: Refactor e2e tests for the scorecard plugin#3245
Open
imykhno wants to merge 3 commits into
Open
RHDHBUGS-3057: Refactor e2e tests for the scorecard plugin#3245imykhno wants to merge 3 commits into
imykhno wants to merge 3 commits into
Conversation
…functions Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
imykhno
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
Code Review by Qodo
1.
|
Changed Packages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
=======================================
Coverage 53.23% 53.23%
=======================================
Files 2413 2413
Lines 86358 86358
Branches 23912 23913 +1
=======================================
Hits 45974 45974
Misses 38907 38907
Partials 1477 1477
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…nts and improve widget handling Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
Review Summary by QodoRefactor scorecard e2e tests with aggregation utilities and improved test structure
WalkthroughsDescription• Refactored e2e test structure with new aggregation constants and utility functions • Reorganized constants from homepageWidgetTitles.ts to aggregations.ts with improved naming • Extracted common test setup logic into reusable homepageWidgetUtils.ts helper functions • Enhanced API utilities with aggregation response waiting and validation capabilities • Improved test organization by grouping related aggregation tests with shared setup Diagramflowchart LR
A["Old Constants<br/>homepageWidgetTitles.ts"] -->|Migrate & Rename| B["New Constants<br/>aggregations.ts"]
C["Scattered Test Setup<br/>Code"] -->|Extract| D["Utility Functions<br/>homepageWidgetUtils.ts"]
E["Basic API Utils<br/>apiUtils.ts"] -->|Enhance| F["Aggregation Response<br/>Waiting & Validation"]
B --> G["Cleaner Test Code<br/>scorecard.test.ts"]
D --> G
F --> G
File Changes1. workspaces/scorecard/packages/app-legacy/e2e-tests/constants/aggregations.ts
|
Signed-off-by: Ihor Mykhno <imykhno@redhat.com>
imykhno
force-pushed
the
scorecard/implement-e2e-tests
branch
from
ca1706a to
1d79f52
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This refactoring follows the merge of #2923. The expectation was that tests will be reviewed and added those tests that are missing to test scorecard aggregation card customization. Additionally, this PR incorporates the feedback and comments raised during the review of #2923.
PR is for:
✔️ Checklist