Skip to content

Show Errors to the user instead of silencly ignore them#3255

Open
asmasarw wants to merge 3 commits into
redhat-developer:mainfrom
asmasarw:fix/silence-error
Open

Show Errors to the user instead of silencly ignore them#3255
asmasarw wants to merge 3 commits into
redhat-developer:mainfrom
asmasarw:fix/silence-error

Conversation

@asmasarw
Copy link
Copy Markdown
Contributor

@asmasarw asmasarw commented May 31, 2026

Show Errors to the user instead of ignore them silencly.

Issues:

  • FLPATH-4284 | [DCM] No React Error Boundary wrapping plugin
  • FLPATH-4245 | [DCM] [Code-only] Service Types tab has no error handling for API failures
  • FLPATH-4243 | [DCM] [Code-only] Policies enabled toggle has no error handling for API failures
image

@asmasarw asmasarw requested review from a team, jkilzi and mareklibra as code owners May 31, 2026 09:32
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented May 31, 2026

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-dcm

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-dcm workspaces/dcm/plugins/dcm none v1.0.0

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

❌ Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.56%. Comparing base (f5a6948) to head (d10c884).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3255      +/-   ##
==========================================
+ Coverage   53.29%   53.56%   +0.26%     
==========================================
  Files        2407     2407              
  Lines       86420    86521     +101     
  Branches    23957    23962       +5     
==========================================
+ Hits        46056    46343     +287     
+ Misses      38887    38700     -187     
- Partials     1477     1478       +1     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from f3ed790
ai-integrations 70.03% <ø> (ø) Carriedforward from f3ed790
app-defaults 69.60% <ø> (ø) Carriedforward from f3ed790
augment 46.39% <ø> (ø) Carriedforward from f3ed790
bulk-import 72.86% <ø> (ø) Carriedforward from f3ed790
cost-management 16.49% <ø> (ø) Carriedforward from f3ed790
dcm 45.17% <79.54%> (+12.31%) ⬆️
extensions 61.79% <ø> (ø) Carriedforward from f3ed790
global-floating-action-button 74.30% <ø> (ø) Carriedforward from f3ed790
global-header 61.63% <ø> (ø) Carriedforward from f3ed790
homepage 51.52% <ø> (ø) Carriedforward from f3ed790
konflux 91.01% <ø> (ø) Carriedforward from f3ed790
lightspeed 68.33% <ø> (ø) Carriedforward from f3ed790
mcp-integrations 85.46% <ø> (ø) Carriedforward from f3ed790
orchestrator 36.51% <ø> (ø) Carriedforward from f3ed790
quickstart 62.88% <ø> (ø) Carriedforward from f3ed790
sandbox 79.42% <ø> (ø) Carriedforward from f3ed790
scorecard 83.84% <ø> (ø) Carriedforward from f3ed790
theme 64.54% <ø> (ø) Carriedforward from f3ed790
translations 8.49% <ø> (ø) Carriedforward from f3ed790
x2a 78.79% <ø> (ø) Carriedforward from f3ed790

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a6948...d10c884. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asmasarw asmasarw force-pushed the fix/silence-error branch from 51216cd to e031d55 Compare May 31, 2026 12:12
@asmasarw asmasarw force-pushed the fix/silence-error branch from 683162d to 5e8d4aa Compare May 31, 2026 12:44
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant