Skip to content

Enable use unknown for catch variables #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datho7561 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable use unknown for catch variables #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/languageservice/services/yamlSchemaService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ export class YAMLSchemaService extends JSONSchemaService {
valid = validator(toValidate);
} catch (e) {
// AJV overflows on recursive/cyclic schemas; attempt to degrade gracefully
console.warn(l10n.t("Schema '{0}' could not be fully validated: {1}", loc, e.message));
console.warn(l10n.t("Schema '{0}' could not be fully validated: {1}", loc, `${e}`));
return;
}
if (!valid) {
Expand Down Expand Up @@ -1400,7 +1400,7 @@ export class YAMLSchemaService extends JSONSchemaService {
const schemaContent = parse(content);
return new UnresolvedSchema(schemaContent, []);
} catch (yamlError) {
const errorMessage = l10n.t("Unable to parse content from '{0}': {1}.", toDisplayString(schemaUri), yamlError);
const errorMessage = l10n.t("Unable to parse content from '{0}': {1}.", toDisplayString(schemaUri), `${yamlError}`);
return new UnresolvedSchema(<JSONSchema>{}, [errorMessage]);
}
},
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"strictNullChecks": false,
"target": "es2020",
"types": ["mocha", "node"],
"useUnknownInCatchVariables": false
},
"include": ["src", "test"],
"exclude": ["node_modules", "out"]
Expand Down
Loading